Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump sigs.k8s.io/controller-tools from 0.9.0 to 0.9.1 #173

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 29, 2022

Bumps sigs.k8s.io/controller-tools from 0.9.0 to 0.9.1.

Release notes

Sourced from sigs.k8s.io/controller-tools's releases.

v0.9.1

changes since v0.9.0

✨ New Features

  • Make topology markers also valid for type definitions (#693)

🐛 Bug Fixes

  • crd/gen: sort FindKubeKinds (#694)
  • crdgen: compare metav1 pkg by ID (#686)

🌱 Others

  • Simplify the LoadRootsWithConfig logic #695

Thanks to all our contributors!

Commits
  • c8fc4d4 Merge pull request #695 from k8s-infra-cherrypick-robot/cherry-pick-687-to-re...
  • 7c994fc ✨ crd/gen: sort FindKubeKinds (#694)
  • cd25c0b Simplify the LoadRootsWithConfig logic
  • 8d80422 Merge pull request #693 from k8s-infra-cherrypick-robot/cherry-pick-692-to-re...
  • 3fe0a0c Make topology markers also valid for type definitions
  • 3c8b410 🐛 crdgen: compare metav1 pkg by ID (#686)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the vendor Pull requests that update vendored dependencies label Jun 29, 2022
@mergify mergify bot requested a review from yati1998 June 29, 2022 09:20
@nixpanic
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.9.1 branch from 96a97be to 1e71e9f Compare June 29, 2022 09:22
@Madhu-1
Copy link
Member

Madhu-1 commented Jun 29, 2022

test -z " M config/crd/bases/csiaddons.openshift.io_csiaddonsnodes.yaml M config/crd/bases/csiaddons.openshift.io_networkfences.yaml M config/crd/bases/csiaddons.openshift.io_reclaimspacecronjobs.yaml M config/crd/bases/csiaddons.openshift.io_reclaimspacejobs.yaml M deploy/controller/crds.yaml" || (echo "files were modified: " ; git status --short ; false)
files were modified:
M config/crd/bases/csiaddons.openshift.io_csiaddonsnodes.yaml
M config/crd/bases/csiaddons.openshift.io_networkfences.yaml
M config/crd/bases/csiaddons.openshift.io_reclaimspacecronjobs.yaml
M config/crd/bases/csiaddons.openshift.io_reclaimspacejobs.yaml
M deploy/controller/crds.yaml
make: *** [Makefile:127: check-all-committed] Error 1
Error: Process completed with exit code 2.

CI is failing as the controller-tool version is getting changes we need to manual push the changes

@nixpanic nixpanic force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.9.1 branch from 1e71e9f to edca3ad Compare June 29, 2022 12:25
@nixpanic
Copy link
Collaborator

CI is failing as the controller-tool version is getting changes we need to manual push the changes

@Madhu-1 , this has been addressed now

@nixpanic nixpanic force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.9.1 branch from edca3ad to 606704b Compare June 29, 2022 12:27
nixpanic
nixpanic previously approved these changes Jun 29, 2022
@mergify mergify bot dismissed nixpanic’s stale review June 29, 2022 12:28

Pull request has been modified.

dependabot bot and others added 2 commits June 29, 2022 14:17
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-tools@v0.9.0...v0.9.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@Rakshith-R Rakshith-R force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.9.1 branch from 606704b to d2bb4c6 Compare June 29, 2022 14:17
@mergify mergify bot merged commit 7254baa into main Jun 29, 2022
@mergify mergify bot deleted the dependabot/go_modules/sigs.k8s.io/controller-tools-0.9.1 branch June 29, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants